drop support for comma separated strings in favor is native lists#620
Open
mhamid3d wants to merge 2 commits intoarthurio:mainfrom
Open
drop support for comma separated strings in favor is native lists#620mhamid3d wants to merge 2 commits intoarthurio:mainfrom
mhamid3d wants to merge 2 commits intoarthurio:mainfrom
Conversation
✅ Deploy Preview for fastapi-filter ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
As this will not pass checks because of tests are using comma separated strings, I will just leave this PR as a reference in case the future maintainer needs a hint on how to support native python lists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FastAPI does not natively support comma separated lists in query parameters. Instead, lists are ingested via repeating key patterns. Forcing comma separated lists also breaks docs and schemas. It is preferred to be consistent with how FastAPI natively handles lists.
In order for FastAPI to parse a field as a list, it must be either annotated with a
Queryor have its default value be aQuery. We can do this inFilterDepends. Checking for Union types is no longer needed and splitting comma string is no longer needed.